Thank you for your patience while I found the time to take a look at this.
Forward - I appreciate you porting this to v3 as I didn’t have time. The only thing I noticed that could be improved about this cog is that when a bot sends an embed message to a user (like the help messages) the report/forwarded message in DMs is blank and doesn’t include the embed content. This point/item also will not disqualify you from anything in this review, it’s only something I noticed while checking it (because my version of forwarding has the same issue, heh).
Highlight - I’ve been using this in some pretty heavy rotation on some of my bots and you have been very responsive when I have submitted PRs or ideas for this cog. Thanks for that.
Modmail - looks good. Couldn’t find anything to comment on here. Works as intended.
samp - When you try to query a server/ip that isn’t on the website, there is an error:
[14/05/2019 08:17] ERROR events on_command_error 202: Exception in command 'samp'
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/discord/ext/commands/core.py", line 79, in wrapped
ret = await coro(*args, **kwargs)
File "/Users/user/Red/cogs/CogManager/cogs/samp/samp.py", line 34, in samp
r = await self.get(req)
File "/Users/user/Red/cogs/CogManager/cogs/samp/samp.py", line 20, in get
return await response.json()
File "/usr/local/lib/python3.7/site-packages/aiohttp/client_reqrep.py", line 1027, in json
aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/plain; charset=utf-8'
Other than that little point on samp everything looks great.