[APPROVED] SauriCogs

#1

Discord Name: Ellie~♡#0001

GitHub Repository (Must be V3): https://github.com/elijabesu/SauriCogs

Description:

Name Description
application Application cog with a Staff Applicant role.
economyraffle A simple cog that gives a pre-specified amount of credits to a randomly picked user.
forwarding Forward all bot DMs to the bot owner, including messages with attachments.
lock Lock @everyone from sending messages except Mods.
mentionable Make unmentionable roles mentionable.
pick Pick a random user or a user with a specified role. Output is user ID. I suggest using it along with nestedcommands and scheduler.
suggestion Suggestion box with a voting system.
assigned TrustyJAID #2
#3

Hi @saurichable, thank you for your patience while I review your repo. I have no major issues with what I have seen and everything below is optional. So I will be approving this but I hope you take the time to read some of the changes suggested.

Commit hash at time of review - fb40e145e3ee4dcebd590c1d772dc60d34351737

AdvancedLock

advancedlock.py

  • Line 2: you import re but never use it
  • Line 9: you import modlog but never use it
  • Line 10: you import pagify and box but never use them
  • Line 192: channels is defined but never used
  • Line 225: channels is defined but never used
  • Line 345 defa is defined but never used
  • You may consider using ctx.guild.default_role to get the role object rather than lookig for the one named @everyone (Optional)

Application

application.py

  • Line 2: you import re but never use it
  • Line 9: you import config and checks but never use them
  • Line 10: you import pagify and box but never use them

Cookies

cookies.py

  • Line 7: you import timedelta but never use it
  • Line 10: you import box but never use it
  • Line 11: you import ReactionPredicate but never use it
  • Line 55: you try to call bot but it is not defined use either self.bot.wait_for or ctx.bot.wait_for
  • Line 59: misspelling of minimum would cause the command to error out
  • Line 60: guild is not defined
  • Line 324-326: These variables are defined and hold the full content of the guilds settings but are not used anywhere
  • Line 621 and 622: see above issue

EconomyRaffle

economyraffle.py

  • Line 2: you import re but never use it
  • Line 3: you import discord but never use it
  • Line 9: you import checks but never use it
  • Line 10: you import pagify and box but never use them
  • Line 12: you import check_global_setting_guildowner but never use it
  • Line 122: bot is defined but never used

Forwarding

forwarding.py

  • Line 1: you import asyncio but never use it
  • Line 2: you import re but never use it
  • Line 5: you import get but never use it
  • Line 9: you import Red but never use it
  • Line 47: You check if the a prefix is used but if the bot has a longer prefix than 1 character such as a mention it will not continue. For example I have a bot with prefix labrys if I send a message starting with like that one time the code will ignore it because it thinks I am calling the bot for a command since you’re only looking for the first character of the bots prefix. This can be simplified by using on_message_without_command in 3.1 or by converting to a context object and checking if the prefix is None.

Lock

lock.py

  • Line 2: you import re but never use it
  • Line 8: you import modlog but never use it
  • Line 9: you import pagify and box but never use them
  • Line 142 and 216: mods is assigned but never used

Mentionable

mentionable.py

  • Line 3: you import Config but never use it
  • You may consider using a discord.Role type hint instead of using get as it will convert to a role object automatically for you. (Optional)

Pick

pick.py

  • Line 1: you import asyncio but never use it
  • Line 2: you import re but never use it
  • Line 4: you import discord but never use it
  • Line 6: you import Any but never use it
  • Line 11: you import Red but never use it

Suggestion

suggestion.py

  • Line 7: you import search but never use it
  • Line 8: you import datetime but never use it
  • Line 11: you import pagify and box but never use them
  • Line 155, 241, 468, and 562: msg is assigned but never used
  • Line 342: bot is defined but never used

UserLog

userlog.py

  • Line 3: you import asyncio but never use it
  • Like 6: you import get but never use it
  • Line 10: you import Translator and cog_i18n but never use them
  • Line 11: you import chat_formatting but never use it
  • Line 12: you import menu and DEFAULT_CONTROLS but never use them
closed #4