Hi Alchez, thank you for your patience while I review your repo.
Commit hash at time of review - f5986aa567689854afd75bdb32b151359cca1cee
- Line 9: You import a library which is blocking and expect to use it in a blocking fashion throughout the cog. By this we mean that everything on the bot has to be written asynchronously. That is to say without expecting one thing to happen before another and without waiting too long in between tasks. All interactions with the internet on the bot should be awaited. The library you’re using is expecting synchronous calls that is first this step then the next step. In this case if the steam servers are down for even a tiny blip or for whatever reason they take a couple seconds to respond your bot will hang until steam responds because this library is not designed to handle the api request asynchronously. You should look at making all usage of the steam library async - there’s approved cog creator examples around- or build your own access to the API for just what you need utilizing aiohttp.
- Line 25-26: These should be on two lines not one.
- Line 383:
OSError is not the correct error that can apply here. You should look at
requests.exceptions.HTTPError to be more explicit although because this library uses requests it is recommended not to be used on the bot at all. In the future for generic exceptions you want to catch without linters going crazy you should use
Exception although that is also not recommended as it can lead to unexpected behavior and you should always be explicit.
Given the simplicity of the cog you have here I will be rejecting your application. I’m willing to consider this at most 2 cogs combined into 1, however it does not meet our minimum requirement of at least 3 cogs and it does not meet our requirements for complexity to be exempt from the 3 cog minimum.
You may re-apply once you have fixed the above listed issues, consider moving the strawpoll portion into its own separate cog with more functionality, have at least 1 more cog, and no sooner than 1 month from today.